Project

General

Profile

Bug #11684

shadow compilers dislike glib2 2.62

Added by Andy Fiddaman about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Andy Fiddaman
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Building gate on a system which has glib2 version 2.62.0 installed fails with gcc 4.4 or smatch; the primary compiler is fine.

An example of the kinds of errors seen:

gcc 4.4.4
cc1: warnings being treated as errors
In file included from /usr/include/glib-2.0/glib/gthread.h:34,
from /usr/include/glib-2.0/glib/gasyncqueue.h:32,
from /usr/include/glib-2.0/glib.h:32,
from ../common/libpolkit-rbac.c:29:

These are because glib2 >= 2.62 suppresses warnings about deprecated declarations in header
files using pragma "GCC diagnostic ignored \"-Wdeprecated-declarations\""
This is not supported before GCC 4.6

smatch
/data/omnios-build/omniosorg/bloody/illumos/usr/src/tools/proto/root_i386-nd/opt
/onbld/bin/i386/smatch: /usr/include/glib-2.0/glib/gspawn.h:76:22: error: Expect
ed } at end of specifier

History

#2

Updated by Andy Fiddaman about 1 year ago

Tested by building gate on an OmniOS system with glib 2.62.0 and one one with 2.60.7

#3

Updated by Electric Monk about 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit e6615f1000c4c6e6b8e18bdc6b077002bdd22526

commit  e6615f1000c4c6e6b8e18bdc6b077002bdd22526
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2019-09-18T13:35:59.000Z

    11684 shadow compilers dislike glib2 2.62
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Dominik Hassler <hadfl@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF