Project

General

Profile

Actions
Copy link

Bug #11705

closed

adding a swap zvol on a DEBUG build blows assert after 11650

Added by Jerry Jelinek almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jerry Jelinek
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

ON a DEBUG build, doing a swapadd on a zvol panics with:

panic[cpu0]/thread=ffffff03321f3bc0: assertion failed: ds->ds_owner tag (0xffffff03307c2c40 0xfffffffff7a9b375), file: ../../common/fs/zfs/dsl_dataset.c, line: 834

Actions
Copy link
 #1

Updated by Jerry Jelinek almost 3 years ago

This is a mismatch on the dmu_objset_own() tag vs. the dmu_objset_disown() tag which was introduced with the changes from 11650.

Actions
Copy link
 #2

Updated by Jerry Jelinek almost 3 years ago

To test this, I first reproduced the problem on a DEBUG build. With the fix, the following now works fine on a DEBUG build.

 # swap -a /dev/zvol/dsk/rpool/jj 
 # swap -d /dev/zvol/dsk/rpool/jj

Actions
Copy link
 #3

Updated by Electric Monk almost 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 262af05a990afe4ad4e40b9e3ec56bfe56b80db5

commit  262af05a990afe4ad4e40b9e3ec56bfe56b80db5
Author: Jerry Jelinek <jerry.jelinek@joyent.com>
Date:   2019-09-18T14:12:21.000Z

    11705 adding a swap zvol on a DEBUG build blows assert after 11650
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF