Project

General

Profile

Actions

Bug #11706

closed

crypto tests need to run 32-bit and 64-bit

Added by Jason King about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tests
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Upstream of Joyent OS-7220:

Today the crypto-tests are only being built to execute in a 32-bit fashion. This isn't good. We should make sure both the 32-bit and 64-bit implementations are exercised, especially as they are often very different on the different architectures. Also, the way that the directory structures for the digest tests and for the aes tests are down are opposite one another. This makes them uniform.
Note, this does not attempt to refactor things such that we can test multiple hardware capabilities at a given time.

Actions #1

Updated by Jason King about 2 years ago

Correction, upstream of OS-7221

Actions #2

Updated by Jason King about 2 years ago

To test, I ran the new 32 & 64 bit crypto test binaries. All ran successfully without error.

Actions #3

Updated by Jason King about 2 years ago

The tests were run on a BE built from a ws w/ that included the changes.

Actions #4

Updated by Electric Monk about 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit e75b2cb046700ccab0100afdcd81f2b860fcca87

commit  e75b2cb046700ccab0100afdcd81f2b860fcca87
Author: Robert Mustacchi <rm@joyent.com>
Date:   2019-09-20T00:57:54.000Z

    11706 crypto tests need to run 32-bit and 64-bit
    Portions contributed by: Jason King <jason.king@joyent.com>
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF