Project

General

Profile

Bug #11714

temporarily disable ZFS TRIM support

Added by Jerry Jelinek 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Based on early real-world experience with the new ZFS TRIM support, we've seen several issues which have lead to corrupted zpools. At this time, it looks like the problems are either in our sd driver support for UNMAP, perhaps in the way that is being used by the new TRIM code, or perhaps some combination of issues. At a minimum, we'll want to add support for an UNMAP blacklist into the driver, similar to what Linux does. However, there is probably more going on here than just that.

As a short-term solution to avoid inadvertently corrupting anyone's zpool, we're going to disable TRIM by default. For development and further testing, a user could still go out of their way to re-enable TRIM.


Related issues

Related to illumos gate - Bug #12051: re-enable ZFS trim by defaultClosed

Actions
Related to illumos gate - Feature #1701: ZFS to support UNMAP/TRIM for SSDClosed2011-10-28

Actions
Related to illumos gate - Bug #11754: ZoL trim port used wrong offset for sd unmapClosed

Actions

History

#1

Updated by Jerry Jelinek 11 months ago

To test this, I booted the OS on a system with a zpool on an SSD. 'zpool status -t' formerly showed that SSD as trimmable, but now it is showing as 'trim unsupported' and running 'zpool trim' on the pool does nothing (as expected).

#2

Updated by Electric Monk 11 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit fb05b94a37411cdc9e6c5cc10b833e410fbf7b79

commit  fb05b94a37411cdc9e6c5cc10b833e410fbf7b79
Author: Jerry Jelinek <jerry.jelinek@joyent.com>
Date:   2019-09-20T16:03:12.000Z

    11714 temporarily disable ZFS TRIM support
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Kody Kantor <kody.kantor@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

#3

Updated by Marcel Telka 6 months ago

  • Related to Bug #12051: re-enable ZFS trim by default added
#4

Updated by Marcel Telka 6 months ago

  • Related to Feature #1701: ZFS to support UNMAP/TRIM for SSD added
#5

Updated by Marcel Telka 6 months ago

  • Related to Bug #11754: ZoL trim port used wrong offset for sd unmap added

Also available in: Atom PDF