Project

General

Profile

Actions
Copy link

Bug #11724

closed

spppcomp: cast between incompatible function types

Added by Toomas Soome about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors with gcc 8:

    ../../common/io/ppp/spppcomp/spppcomp.c:125:2: error: cast between incompatible function types from 'void (*)(queue_t *, mblk_t *)' {aka 'void (*)(struct queue *, struct msgb *)'} to 'int (*)()' [-Werror=cast-function-type]
      (int (*)())spppcomp_rput, /* qi_putp */
      ^
    ../../common/io/ppp/spppcomp/spppcomp.c:126:2: error: cast between incompatible function types from 'void (*)(queue_t *)' {aka 'void (*)(struct queue *)'} to 'int (*)()' [-Werror=cast-function-type]
      (int (*)())spppcomp_rsrv, /* qi_srvp */
      ^
    ../../common/io/ppp/spppcomp/spppcomp.c:135:2: error: cast between incompatible function types from 'void (*)(queue_t *, mblk_t *)' {aka 'void (*)(struct queue *, struct msgb *)'} to 'int (*)()' [-Werror=cast-function-type]
      (int (*)())spppcomp_wput, /* qi_putp */
      ^
    ../../common/io/ppp/spppcomp/spppcomp.c:136:2: error: cast between incompatible function types from 'void (*)(queue_t *)' {aka 'void (*)(struct queue *)'} to 'int (*)()' [-Werror=cast-function-type]
      (int (*)())spppcomp_wsrv, /* qi_srvp */
      ^
    cc1: all warnings being treated as errors

Actions
Copy link
 #1

Updated by Electric Monk about 4 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit c4d76aa4b703811c0527424e3c63151eb77b9972

commit  c4d76aa4b703811c0527424e3c63151eb77b9972
Author: Toomas Soome <tsoome@me.com>
Date:   2019-09-30T20:01:22.000Z

    11724 spppcomp: cast between incompatible function types
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF