Project

General

Profile

Actions

Bug #11736

closed

Stop using $VERSION for the genunix label

Added by John Levon about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

We currently use $VERSION, which encodes the current git HEAD, as the genunix label. This is subsequently used by
kernel modules for uniquifying. The problem here is that if we make a commit, then try to rebuild a kernel module
(rather than a nightly or make in uts), it will fail, as the two labels now differ.

Now we encode the git head inside /etc/versions/build and the kernel, there is no real need to do this. Let's
replace this label with a fixed "genunix" label, so we can rebuild individual modules easily without issues.

Actions #1

Updated by Electric Monk about 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 06abc743fea52d63ff21197e28e32fe2aa5b402a

commit  06abc743fea52d63ff21197e28e32fe2aa5b402a
Author: John Levon <john.levon@joyent.com>
Date:   2019-10-09T15:32:27.000Z

    11736 Stop using $VERSION for the genunix label
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF