Project

General

Profile

Bug #11747

zpool iostat -v no longer shows titles for log/bias sections

Added by Andy Fiddaman about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

This looks like it was a mismerge from the upstream ZFS Allocation Classes commit.

Before pool allocation classes:

% pfexec ./zpool iostat -v test
               capacity     operations    bandwidth
pool        alloc   free   read  write   read  write
----------  -----  -----  -----  -----  -----  -----
test         624K   895M      0      0  1.86K  8.47K
  c6t1d0     624K   895M      0      0  1.85K  7.30K
logs            -      -      -      -      -      -
  c3t0d0        0  7.50G      0      0     11  1.17K
----------  -----  -----  -----  -----  -----  -----

and after:

% pfexec zpool iostat -v test
               capacity     operations    bandwidth
pool        alloc   free   read  write   read  write
----------  -----  -----  -----  -----  -----  -----
test         624K   895M      0      0  1.86K  8.46K
  c6t1d0     624K   895M      0      0  1.85K  7.29K
  c3t0d0        0  7.50G      0      0     11  1.17K
----------  -----  -----  -----  -----  -----  -----

Looking at the ZoL code, they have logic to print these headers. We're missing some other commits that prevent me taking the code exactly as it is but the fix looks pretty easy.


Related issues

Related to illumos gate - Bug #10601: Pool allocation classesClosed2019-03-28

Actions

History

#1

Updated by Andy Fiddaman about 1 year ago

  • Related to Bug #10601: Pool allocation classes added
#2

Updated by Andy Fiddaman about 1 year ago

  • Description updated (diff)
#4

Updated by Andy Fiddaman about 1 year ago

  • Description updated (diff)
#5

Updated by Andy Fiddaman about 1 year ago

  • Subject changed from zpool iostat -v no longer shows titles for log sections to zpool iostat -v no longer shows titles for log/bias sections
#6

Updated by Electric Monk about 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit c4e4d4102c8a8c2cc936dd971bdafe4ec52fd4cf

commit  c4e4d4102c8a8c2cc936dd971bdafe4ec52fd4cf
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2019-09-25T14:21:51.000Z

    11747 zpool iostat -v no longer shows titles for log/bias sections
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Jim Klimov <jim@cos.ru>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF