Actions
Bug #11747
closed
zpool iostat -v no longer shows titles for log/bias sections
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:
Description
This looks like it was a mismerge from the upstream ZFS Allocation Classes commit.
Before pool allocation classes:
% pfexec ./zpool iostat -v test
capacity operations bandwidth
pool alloc free read write read write
---------- ----- ----- ----- ----- ----- -----
test 624K 895M 0 0 1.86K 8.47K
c6t1d0 624K 895M 0 0 1.85K 7.30K
logs - - - - - -
c3t0d0 0 7.50G 0 0 11 1.17K
---------- ----- ----- ----- ----- ----- -----
and after:
% pfexec zpool iostat -v test
capacity operations bandwidth
pool alloc free read write read write
---------- ----- ----- ----- ----- ----- -----
test 624K 895M 0 0 1.86K 8.46K
c6t1d0 624K 895M 0 0 1.85K 7.29K
c3t0d0 0 7.50G 0 0 11 1.17K
---------- ----- ----- ----- ----- ----- -----
Looking at the ZoL code, they have logic to print these headers. We're missing some other commits that prevent me taking the code exactly as it is but the fix looks pretty easy.
Related issues
Updated by Andy Fiddaman over 3 years ago
- Related to Bug #10601: Pool allocation classes added
Updated by Andy Fiddaman over 3 years ago
Review at https://illumos.org/rb/r/2347/
Updated by Andy Fiddaman over 3 years ago
- Subject changed from zpool iostat -v no longer shows titles for log sections to zpool iostat -v no longer shows titles for log/bias sections
Updated by Electric Monk over 3 years ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
git commit c4e4d4102c8a8c2cc936dd971bdafe4ec52fd4cf
commit c4e4d4102c8a8c2cc936dd971bdafe4ec52fd4cf
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date: 2019-09-25T14:21:51.000Z
11747 zpool iostat -v no longer shows titles for log/bias sections
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Jim Klimov <jim@cos.ru>
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions