Project

General

Profile

Actions

Bug #11755

closed

loader: command_lsmod does show garbage on screen

Added by Toomas Soome almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Should use strlcpy and not strncpy:)

Testing done: lsmod does not show garbage.


Related issues

Related to illumos gate - Bug #11757: installboot: install vbr only when stage2 is installedClosedToomas Soome

Actions
Actions #1

Updated by Joshua M. Clulow almost 3 years ago

  • Related to Bug #11757: installboot: install vbr only when stage2 is installed added
Actions #2

Updated by Toomas Soome almost 3 years ago

Toomas Soome wrote:

Should use strlcpy and not strncpy:)

Testing done: lsmod does not show garbage.

There can still be possible issues with overflowing PTOV pointers, but we will investigate such cases later.

Actions #3

Updated by Electric Monk almost 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit e10751a53e4fcc2850e57448ad13dc3caf40595e

commit  e10751a53e4fcc2850e57448ad13dc3caf40595e
Author: Toomas Soome <tsoome@me.com>
Date:   2019-09-30T19:40:57.000Z

    11755 loader: command_lsmod does show garbage on screen
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF