Project

General

Profile

Actions
Copy link

Bug #11775

closed

loader: reset FONT_MANUAL flag on resolution change

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The FONT_MANUAL flag is set on font when font is set by user (in script or command line) to preserve font setting. However, on resolution change, we want to have font auto selection fully operational because user selected font may not be usable - like on case when we set to bios text mode, we can only have font with glyph size 8x16.

Testing done:
in bios mode used both methods to select font (loadfont command and set screen-font) other than 8x16, then switched framebuffer off to get vga text mode. Observerd the text mode has usable font.

Also did change framebuffer resolution with framebuffer set and observed the font change.

Note: we could preserve the user selected font when only the depth is changed (only possible in BIOS mode, uefi only has depth 32), but I do not think it is worth the effort.

Actions
Copy link
 #1

Updated by Toomas Soome over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 337411fcf93041fb98fbfba6506e4128cd3e1933

commit  337411fcf93041fb98fbfba6506e4128cd3e1933
Author: Toomas Soome <tsoome@me.com>
Date:   2019-10-04T06:48:02.000Z

    11775 loader: reset FONT_MANUAL flag on resolution change
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Jim Klimov <jim@cos.ru>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF