Project

General

Profile

Bug #11777

bootadm: list-menu -o entry=X does not list details when bootfs has colon

Added by Toomas Soome about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The current check is using strchr() to detect colon in bootfs name. The check was built based on assumption that only disk device descriptor may contain the colon, however, we also allow colon in zfs dataset name. Since disk descriptors have colon at the end of the name, we can adjust the check to test the last char in the name.

Testing done:

$ ./bootadm list-menu -o entry=27
the location for the active menu is: /rpool/boot/menu.lst

Title:       openindiana-2019:09:26
Timeout:     10
Console:     text
Bootfs:      rpool/ROOT/openindiana-2019:09:26
Kernel:      /platform/i86pc/kernel/amd64/unix

Modules:
Name:        boot_archive
Path:        /platform/i86pc/${ISADIR}/boot_archive
Type:        rootfs
Status:      Load

Name:        boot_archive.hash
Path:        /platform/i86pc/${ISADIR}/boot_archive.hash
Type:        hash
Status:      Load

$

#1

Updated by Electric Monk about 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 160df5799e3f9b7bb50684728c35ab9849ff694c

commit  160df5799e3f9b7bb50684728c35ab9849ff694c
Author: Toomas Soome <tsoome@me.com>
Date:   2019-10-09T15:29:42.000Z

    11777 bootadm: list-menu -o entry=X does not list details when bootfs has colon
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF