Project

General

Profile

Actions
Copy link

Bug #11795

closed

ksslf: cast between incompatible function types

Added by Toomas Soome over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with gcc 8:

    ../../common/inet/kssl/ksslrec.c:90:33: error: cast between incompatible function types from 'void (*)(SHA1_CTX *, const void *, size_t)' {aka 'void (*)(struct <anonymous> *, const void *, long unsigned int)'} to 'void (*)(void *, uchar_t *, uint32_t)' {aka 'void (*)(void *, unsigned char *, unsigned int)'} [-Werror=cast-function-type]
          (hashinit_func_t)SHA1Init, (hashupdate_func_t)SHA1Update,
                                     ^
    cc1: all warnings being treated as errors

The problem here is that MD5Update and SHA1Update have different sized third argument, so we need to use wrapper.

Actions
Copy link
 #1

Updated by Electric Monk over 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 00a2bb8f2626ebdf8b00480ccc705df3502feab1

commit  00a2bb8f2626ebdf8b00480ccc705df3502feab1
Author: Toomas Soome <tsoome@me.com>
Date:   2019-10-11T19:06:44.000Z

    11795 ksslf: cast between incompatible function types
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Garrett D'Amore <gdamore@racktopsystems.com>

Actions
Copy link

Also available in: Atom PDF