Project

General

Profile

Actions

Bug #11804

closed

xpv_psm: cast between incompatible function types

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors with gcc 8:

    ../../i86xpv/io/psm/xpv_psm.c:297:25: error: cast between incompatible function types from 'void (*)(char *, struct regs *)' to 'uint_t (*)(char *, char *)' {aka 'unsigned int (*)(char *, char *)'} [-Werror=cast-function-type]
      if (!psm_add_nmintr(0, (avfunc) xen_psm_nmi_intr,
                             ^
    cc1: all warnings being treated as errors

Testing done: build/install/boot. no xen setup however.

Actions #1

Updated by Toomas Soome over 3 years ago

  • Description updated (diff)
Actions #2

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 4224cf35431a1b80d14862409ecf0beeaa49e0d8

commit  4224cf35431a1b80d14862409ecf0beeaa49e0d8
Author: Toomas Soome <tsoome@me.com>
Date:   2019-11-14T08:17:34.000Z

    11804 xpv_psm: cast between incompatible function types
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF