Project

General

Profile

Bug #11806

SMB server sends malformed responses on error

Added by Andrew Stormont about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The SMB2 dispatch code can emit partially constructed responses if a request handler returns SDRC_ERROR. This is easily observed over WireShark when running the WPTS (Windows Protocol Test Suites). One particular test case shows this very clearly: the InvalidCreateRequestStructureSize test found in the CreateClose section. Attached is a packet capture showing this.


Files

InvalidCreateRequestStructureSize.pcapng (11.6 KB) InvalidCreateRequestStructureSize.pcapng Frame 21 shows a malformed response Andrew Stormont, 2019-10-11 03:50 PM

History

#3

Updated by Andrew Stormont about 1 year ago

  • Description updated (diff)
#4

Updated by Electric Monk about 1 year ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 541826a8134c92e67fc603ded1699287feb4cca2

commit  541826a8134c92e67fc603ded1699287feb4cca2
Author: Andrew Stormont <astormont@racktopsystems.com>
Date:   2019-10-19T16:50:07.000Z

    11806 SMB server sends malformed responses on error
    Reviewed by: Vitaliy Gusev <vgusev@racktopsystems.com>
    Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
    Reviewed by: Garrett D'Amore <gdamore@racktopsystems.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF