Project

General

Profile

Bug #11834

SMB authentication service stops after flood

Added by Gordon Ross about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While testing at the SDC plug-fest, found the smbd authentication service stopped (after an "authentication flood" test).
No thread remains doing listen/accept on the authsvc socket.

History

#1

Updated by Gordon Ross about 1 year ago

The system log shows that the "auth flood" client managed to (temporarily) run us short of memory, so attempts to create a new authentication context failed, and then the accept loop terminated. We should not terminate the accept loop in that case.

#2

Updated by Gordon Ross about 1 year ago

I'm not exactly sure how to reproduce this failure. It happened with a stress test we don't have.
We verified the fix at the SDC 2019 plug-fest.

#3

Updated by Electric Monk about 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 2a2a3aab3979d4b28c1b624aa75f71cad72c4220

commit  2a2a3aab3979d4b28c1b624aa75f71cad72c4220
Author: Gordon Ross <gwr@nexenta.com>
Date:   2019-10-19T13:02:48.000Z

    11834 SMB authentication service stops after flood
    Reviewed by: Roman Strashkin <roman.strashkin@nexenta.com>
    Reviewed by: Evan Layton <evan.layton@nexenta.com>
    Reviewed by: Matt Barden <matt.barden@nexenta.com>
    Reviewed by: Andy Stormont <AStormont@racktopsystems.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Also available in: Atom PDF