Project

General

Profile

Actions
Copy link

Bug #11837

closed

tests/pf_key/acquire-compare is racy

Added by John Levon over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Levon
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

There are multiple issues with this test that can cause spurious failures.

Actions
Copy link
 #1

Updated by John Levon over 3 years ago

Some specific issues:

- we need to pause a while after each ping/telnet invocation to make sure monitor log records aren't interleaved
 - we need to wait at the start and end to make sure the monitor is up and down properly
 - instead of pfiles, which can race against telnet startup, just specify a telnet port
Actions
Copy link
 #2

Updated by Dan McDonald over 3 years ago

telnet is probably insufficient for this test, as AFAICT you cannot set the LOCAL port as well, and we really need to specify the 4-tuple to avoid using pfiles.

Actions
Copy link
 #3

Updated by Electric Monk over 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 3dae5456c609a0bdfeffc8d1c0dc436db6ab3436

commit  3dae5456c609a0bdfeffc8d1c0dc436db6ab3436
Author: John Levon <john.levon@joyent.com>
Date:   2019-10-28T21:10:40.000Z

    11837 tests/pf_key/acquire-compare is racy
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF