Project

General

Profile

Feature #11848

Remove STRUIO_IP support from ip_cksum.c

Added by Jason King about 1 year ago. Updated about 1 year ago.

Status:
New
Priority:
Normal
Assignee:
Category:
networking
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Hard
Tags:
Gerrit CR:

Description

The dblk STRUIOP_IP flag was introduced in 1994 as a consolidation private interface to speed up FDDI processing.

It is not used anywhere in illumos-gate, it is consolidation private, and from the information available, appears to only work with Synchronous STREAMS compatible drivers, and it makes the ip_cksum() source an largely unreadable complicated mess. Removing the support allows for a substantial simplification of the function.


Files

mblk.tar (30.5 KB) mblk.tar Test code Jason King, 2019-10-18 02:27 AM

History

#1

Updated by Jason King about 1 year ago

As part of the testing, the attached mblk.tar code was created. It extracts both the new and old ip_cksum() code and runs it against a contrived mblk_t chain of random data to compare the results (to make sure the new code returns the same checksum as the existing code). It was tested on both x86 and sparc successfully.

Also available in: Atom PDF