Project

General

Profile

Actions

Bug #11863

closed

SMB2 CREATE should validate impersonation level

Added by Andrew Stormont over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While we don't use the impersonation level we should be ensuring that the client hasn't passed a bogus value for it:

"If the ImpersonationLevel in the request is not one of the values specified in section 2.2.13, the server SHOULD fail the request with STATUS_BAD_IMPERSONATION_LEVEL."

This impacts the follow WPTS test cases:

CreateCloseTestCaseS640
CreateCloseTestCaseS733
CreateCloseTestCaseS179

Actions #1

Updated by Andrew Stormont over 2 years ago

  • Description updated (diff)
Actions #2

Updated by Electric Monk about 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit a8661d6d41898fc90e65007115e5c3be62013bbf

commit  a8661d6d41898fc90e65007115e5c3be62013bbf
Author: Andrew Stormont <astormont@racktopsystems.com>
Date:   2019-11-19T23:06:15.000Z

    11863 SMB2 CREATE should validate impersonation level
    11864 SMB2 CREATE should reject absolute paths
    11865 SMB2 CREATE should check MxAc create context size
    Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
    Reviewed by: Garrett D'Amore <gdamore@racktopsystems.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF