Project

General

Profile

Actions
Copy link

Bug #11864

closed

SMB2 CREATE should reject absolute paths

Added by Andrew Stormont over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Andrew Stormont
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

The SMB2 documentation says we should reject CREATE requests with absolute paths but we don't currently do that:

"If the file name length is greater than zero and the first character is a path separator character, the server MUST fail the request with STATUS_INVALID_PARAMETER."

This impacts the follow WPTS test cases:

CreateCloseTestCaseS249
CreateCloseTestCaseS122
CreateCloseTestCaseS443
CreateCloseTestCaseS418
CreateCloseTestCaseS406
CreateCloseTestCaseS379
CreateCloseTestCaseS367
CreateCloseTestCaseS346
CreateCloseTestCaseS331
CreateCloseTestCaseS285
CreateCloseTestCaseS273

Actions
Copy link
 #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit a8661d6d41898fc90e65007115e5c3be62013bbf

commit  a8661d6d41898fc90e65007115e5c3be62013bbf
Author: Andrew Stormont <astormont@racktopsystems.com>
Date:   2019-11-19T23:06:15.000Z

    11863 SMB2 CREATE should validate impersonation level
    11864 SMB2 CREATE should reject absolute paths
    11865 SMB2 CREATE should check MxAc create context size
    Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
    Reviewed by: Garrett D'Amore <gdamore@racktopsystems.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF