Actions
Bug #11865
closed
SMB2 CREATE should check MxAc create context size
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
Description
The SMB2 server should fail with STATUS_INVALID_PARAMETER if the size of a MxAc create context is not large enough to hold the optional timestamp value. This is something the WPTS checks for by issuing a bogus CREATE request with a MxAc create context with a size of 4 bytes (the spec says it MUST be either 0 or 8 bytes long):
"The Data in the Buffer field of the SMB2_CREATE_CONTEXT MUST either contain the following structure or be empty (0 bytes in length)."
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-smb2/5ea40835-5d40-4e85-977d-13cd745d3af8
This impacts the following WPTS test case:
InvalidCreateRequestStructureSize
Updated by Andrew Stormont about 2 years ago
- Subject changed from SMB2 CREATE should validate create context sizes to SMB2 CREATE should check MxAc create context size
- Description updated (diff)
Updated by Electric Monk about 2 years ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
git commit a8661d6d41898fc90e65007115e5c3be62013bbf
commit a8661d6d41898fc90e65007115e5c3be62013bbf
Author: Andrew Stormont <astormont@racktopsystems.com>
Date: 2019-11-19T23:06:15.000Z
11863 SMB2 CREATE should validate impersonation level
11864 SMB2 CREATE should reject absolute paths
11865 SMB2 CREATE should check MxAc create context size
Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
Reviewed by: Garrett D'Amore <gdamore@racktopsystems.com>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions