Actions
Bug #11870
closedcleanup sys/ddi_implfuncs.h
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:
Description
There are a few inconsistencies in
sys/ddi_implfuncs.h
that could stand to be cleaned up:
- cstyle violations reported by
git pbchk
- many different layout styles for forward declarations and comments
- some functions that appear not to be defined anywhere else, at least anymore
void
missing from empty argument listsextern
inconsistently used when it should be everywhere- see past on-list discussion: https://illumos.topicbox.com/groups/developer/Td32b4d2ac381012a-M14cb1afe085f9617177eb1b0
Updated by Joshua M. Clulow over 3 years ago
Testing Notes¶
I built a copy of the gate before and after this change, and then ran wsdiff
against the entire (non-DEBUG) proto area. The only .text
section differences were in genunix
, and they seemed to be the usual minor differences you'd expect from shuffling header file lines around.
I also booted the RTI build in an OpenIndiana VM and ran the os-tests
suite:
user@oi0:/home/user$ /opt/os-tests/bin/ostest Test: /opt/os-tests/tests/ddi_ufm/ufm-test-setup (run as root) [00:01] [PASS] Test: /opt/os-tests/tests/ddi_ufm/ufm-test (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/ddi_ufm/ufm-test-cleanup (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/file-locking/runtests.32 (run as user) [00:21] [PASS] Test: /opt/os-tests/tests/file-locking/runtests.64 (run as user) [00:21] [PASS] Test: /opt/os-tests/tests/i386/ldt (run as root) [00:06] [PASS] Test: /opt/os-tests/tests/i386/badseg (run as root) [00:06] [PASS] Test: /opt/os-tests/tests/pf_key/acquire-compare (run as root) [00:43] [PASS] Test: /opt/os-tests/tests/pf_key/kmc-update (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/sdevfs/sdevfs_eisdir (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_aslr (run as root) [00:04] [PASS] Test: /opt/os-tests/tests/secflags/secflags_core (run as root) [00:01] [PASS] Test: /opt/os-tests/tests/secflags/secflags_dts (run as root) [00:13] [PASS] Test: /opt/os-tests/tests/secflags/secflags_elfdump (run as root) [00:01] [PASS] Test: /opt/os-tests/tests/secflags/secflags_forbidnullmap (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_limits (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_noexecstack (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_proc (run as root) [00:01] [PASS] Test: /opt/os-tests/tests/secflags/secflags_psecflags (run as root) [00:11] [PASS] Test: /opt/os-tests/tests/secflags/secflags_syscall (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_truss (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_zonecfg (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/sigqueue/sigqueue_queue_size (run as user) [00:00] [PASS] Test: /opt/os-tests/tests/sockfs/conn (run as root) [00:05] [PASS] Test: /opt/os-tests/tests/sockfs/dgram (run as root) [00:05] [PASS] Test: /opt/os-tests/tests/sockfs/drop_priv (run as root) [00:07] [PASS] Test: /opt/os-tests/tests/sockfs/nosignal (run as root) [00:02] [PASS] Test: /opt/os-tests/tests/sockfs/sockpair (run as root) [00:10] [PASS] Test: /opt/os-tests/tests/stress/dladm-kstat (run as root) [00:20] [PASS] Results Summary PASS 29 Running Time: 00:03:05 Percent passed: 100.0% Log directory: /var/tmp/test_results/20191101T195236 user@oi0:/home/user$ uname -v rti-master-0-gcead8aaede
Updated by Electric Monk over 3 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit c00e8e9ee0eb7384f171971ad938063426b731f7
commit c00e8e9ee0eb7384f171971ad938063426b731f7 Author: Joshua M. Clulow <josh@sysmgr.org> Date: 2019-11-02T04:47:34.000Z 11870 cleanup sys/ddi_implfuncs.h Reviewed by: Matthias Scheler <matthias.scheler@wdc.com> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>
Actions