Project

General

Profile

Actions
Copy link

Bug #11881

closed

loader: zfs_fmtdev can crash when pool discovery did fail and we have no spa

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

FreeBSD commit: https://svnweb.freebsd.org/changeset/base/353757

When zfs probe did fail and no spa was created, but zfs_fmtdev() is called, we will crash while dereferencing spa (NULL pointer dereference).

Tested with userland loader/zfs reader app where the issue did reveal itself (app is not yet in illumos tree) - did confirm the crash does not happen any more.

Actions
Copy link
 #1

Updated by Toomas Soome over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit c2e9ac5c28eb1a9d5839d914b821e44a7dfdc767

commit  c2e9ac5c28eb1a9d5839d914b821e44a7dfdc767
Author: Toomas Soome <tsoome@me.com>
Date:   2019-10-28T16:00:23.000Z

    11881 loader: zfs_fmtdev can crash when pool discovery did fail and we have no spa
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions
Copy link

Also available in: Atom PDF