Project

General

Profile

Actions
Copy link

Bug #11883

closed

loader: zio_checksum_verify should check byteswap

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

We do have both native and byteswap checksum callbacks in place but the selection is not wired.

Testing done: build/install/boot.

Additionally, with disk image of pool created on sparc, I did add debug printouts to get byteswap value and checksum status:

L0 DMU objset] DVA0=<0:18006400:200> DVA1=<0:1c006400:200> DVA2=<0:2001b800:200> 1000L/200P F=56 B=31/31 triple BE cksum=9bdd2561c:40df25e67ec:dba5e67b5d8c:1f82b576ab64b7
vdev_read: offset: 18406400, size: 200
zio_checksum_verify: byteswap: 1
zio_checksum_verify: OK

However, note that loader is not implementing all proper byteswaps, so even as we read out MOS (above), we can not interpret it (yet).

Actions
Copy link
 #1

Updated by Toomas Soome over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk over 3 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit ece0bc848de931052064be9faf07f4e44c150a15

commit  ece0bc848de931052064be9faf07f4e44c150a15
Author: Toomas Soome <tsoome@me.com>
Date:   2019-10-29T18:27:42.000Z

    11883 loader: zio_checksum_verify should check byteswap
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Andy Stormont <AStormont@racktopsystems.com>
    Reviewed by: Kody Kantor <kody.kantor@joyent.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF