Project

General

Profile

Actions

Bug #11943

closed

Fix out-of-order ZIL txtype lost on hardlinked files

Added by Andy Fiddaman over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

When replaying ZIL records involving the removal of a link from a hardlinked file, the code erroneously determines that the object was completely removed, causing dropped replay operations.

ZoL has a fix for this and an associated test.

commit 8e556c5ebc7b66caf2cdcc561b6644f9f8437a6d
Author: Chunwei Chen <david.chen@nutanix.com>
Date:   Tue Aug 13 20:21:27 2019 -0700

    Fix out-of-order ZIL txtype lost on hardlinked files

    We should only call zil_remove_async when an object is removed. However,
    in current implementation, it is called whenever TX_REMOVE is called. In
    the case of hardlinked file, every unlink will generate TX_REMOVE and
    causing operations to be dropped even when the object is not removed.

    We fix this by only calling zil_remove_async when the file is fully
    unlinked.
Actions

Also available in: Atom PDF