Project

General

Profile

Actions

Bug #11965

closed

crypto tests only test multi-part operations a byte at a time

Added by Jason King over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tests
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Upstream of Joyent OS-7954:

Our current crypto test suite tests the various crypto mechanisms in two ways – first using the single operation functions (such as C_Digest()), and then using the multi-part operations (e.g. C_DigestUpdate() followed by C_DigestFinal().
When testing the multi part operations, the current tests always call the xxUpdate functions with a single byte of data at a time. For at least some mechanisms (e.g. CKM_AES_CBC_PAD), it would be good to also test with larger input sizes.

Actions #1

Updated by Joshua M. Clulow over 2 years ago

Testing Notes (from Jason)

To test, I booted a BE with the change and ran the new crypto tests (which all completed successfully).

As mentioned in the original email I sent for review, the CTR tests explicitly don’t test anything but AES_BLOCK_LEN (16) byte segments. Until #11966 is integrated (next on my list of things to upstream), other sizes will fail for CTR mode.

Actions #2

Updated by Electric Monk over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 77de87d27c7e8b4063deeab95edde5173a6a003d

commit  77de87d27c7e8b4063deeab95edde5173a6a003d
Author: Jason King <jason.king@joyent.com>
Date:   2019-11-19T16:52:51.000Z

    11965 crypto tests only test multi-part operations a byte at a time
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF