Project

General

Profile

Actions
Copy link

Bug #11973

closed

tem: we only can translate colors 0-7

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Apply correct checks for to be translated colors. Actually loader does not allow to specify values 8-15, but we still want correct if statements.

About testing done:
I only found the issue by reading the code, in loader we can set colors, but loader does not allow to set [8-15] directly.. So it really is just build/install/run + knowing that we are not reading past the end of translation array.

Actions
Copy link
 #1

Updated by Toomas Soome over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 3128654191cf8267843c8a40c4e0f3ac65f599f1

commit  3128654191cf8267843c8a40c4e0f3ac65f599f1
Author: Toomas Soome <tsoome@me.com>
Date:   2019-11-21T06:40:57.000Z

    11973 tem: we only can translate colors 0-7
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF