Project

General

Profile

Actions

Bug #11979

closed

libshell: bitwise comparison always evaluates to false

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error with gcc 8:

    ../common/sh/nvtree.c: In function 'nv_attribute':
    ../common/sh/nvtree.c:431:34: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
       if((attr&NV_NOPRINT|NV_INTEGER)==NV_NOPRINT)
                                      ^~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit c4fc965c904c30ee88c7ec42768b39cdbb328de9

commit  c4fc965c904c30ee88c7ec42768b39cdbb328de9
Author: Toomas Soome <tsoome@me.com>
Date:   2019-12-03T18:47:59.000Z

    11979 libshell: bitwise comparison always evaluates to false
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF