Project

General

Profile

Actions

Bug #11997

closed

format: cstyle cleanup

Added by Toomas Soome over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

cstyle update for files we just did touch.

Testing done: build/install/boot and using format command.

Dan McDonald further tested it by doing dis(1) comparisons:

WS-nowhere-WS[141]% diff /tmp/{orig,new}
12927c12927
< sup_pushtoken+0x3b: 68 38 09 00 00 pushl $0x938
---
sup_pushtoken+0x3b: 68 f9 08 00 00 pushl $0x8f9
13214c13214
< input+0x2f: 68 df 01 00 00 pushl $0x1df
---
input+0x2f: 68 b6 01 00 00 pushl $0x1b6
14226c14226
< input+0xde8: 68 4b 04 00 00 pushl $0x44b
---
input+0xde8: 68 21 04 00 00 pushl $0x421
14645c14645
< input+0x1391: 68 f5 04 00 00 pushl $0x4f5
---
input+0x1391: 68 cb 04 00 00 pushl $0x4cb
WS-nowhere-WS[1]%

All of those are assert()s with linenos changed by this commit.

Actions #1

Updated by Toomas Soome over 2 years ago

  • Description updated (diff)
Actions #2

Updated by Toomas Soome over 2 years ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk over 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit edbad4fe075c5178507eaf0bfb85aa903b66bf91

commit  edbad4fe075c5178507eaf0bfb85aa903b66bf91
Author: Toomas Soome <tsoome@me.com>
Date:   2019-12-06T15:53:56.000Z

    11997 format: cstyle cleanup
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF