Project

General

Profile

Actions
Copy link

Feature #12014

closed

virtio_init_complete() comment should describe interrupt type parameter

Added by Joshua M. Clulow over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Joshua M. Clulow
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

The Virtio framework includes a function that accepts a mask of interrupt types:

 int
 virtio_init_complete(virtio_t *vio, int allowed_interrupt_types)

It would help if the comment above the function described how to use it correctly, including the fact that a value of zero will allow any type of interrupt.

Clean up any other minor typographical errors seen on the way.

Actions
Copy link
 #1

Updated by Joshua M. Clulow over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk over 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit c00b0288a75782c75abd0b9959021fd2417c8a28

commit  c00b0288a75782c75abd0b9959021fd2417c8a28
Author: Joshua M. Clulow <josh@sysmgr.org>
Date:   2019-11-24T17:14:51.000Z

    12014 virtio_init_complete() comment should describe interrupt type parameter
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF