Project

General

Profile

Bug #12034

zfs test send_encrypted_props can fail

Added by Jason King 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
tests
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The zfs test send_encrypted_props can fail with:

13:39:06.30 /opt/zfs-tests/tests/functional/rsend/send_encrypted_props: line 194: md5digest: not found

Replacing the md5digest call with 'digest -a md5' likely will fix this.


Related issues

Has duplicate illumos gate - Bug #12162: zfstest send_encrypted_props test uses incorrect md5 toolClosed

Actions

History

#1

Updated by Jason King 7 months ago

  • Has duplicate Bug #12162: zfstest send_encrypted_props test uses incorrect md5 tool added
#2

Updated by Kody Kantor 7 months ago

To test this fix I manually ran the test in question:

root@oi:/opt/zfs-tests/tests/functional/rsend# ./setup
root@oi:/opt/zfs-tests/tests/functional/rsend# ./send_encrypted_props
ASSERTION: 'zfs recv' must properly handle encryption properties
SUCCESS: eval echo 'password' > /testpool/pkey
SUCCESS: zfs create testpool/ds
SUCCESS: zfs create testpool/ds/ds1
 [...]
NOTE: Must be able to receive incremental stream with props to encrypted
SUCCESS: eval zfs send -p testpool/ds@snap1 > /testpool/sendfile
SUCCESS: eval zfs recv -x encryption testpool/crypt/recv < /testpool/sendfile
SUCCESS: test testpool/crypt == testpool/crypt
SUCCESS: test aes-256-ccm == aes-256-ccm
SUCCESS: test passphrase == passphrase
SUCCESS: test yes == yes
SUCCESS: test b6d81b360a5672d80c27430f39153e2c == b6d81b360a5672d80c27430f39153e2c
SUCCESS: zfs destroy -r testpool/crypt/recv
 [...]
NOTE: Performing local cleanup via log_onexit (cleanup)
NOTE: Dataset does not exist. (testpool/recv)
SUCCESS: zfs destroy -r testpool/crypt
SUCCESS: zfs destroy -r testpool/ds
SUCCESS: rm /testpool/sendfile
SUCCESS: rm /testpool/pkey
'zfs recv' properly handles encryption properties
root@oi:/opt/zfs-tests/tests/functional/rsend# echo $?
0

#3

Updated by Electric Monk 7 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit e830fb12ed60bbd91c87459b169b5d1cc6ef0b9e

commit  e830fb12ed60bbd91c87459b169b5d1cc6ef0b9e
Author: Kody A Kantor <kody@kkantor.com>
Date:   2020-01-14T16:08:49.000Z

    10241 ZFS not detecting faulty spares in a timely manner
    12132 zfs-retire agent crashes fmd on systems without vdev devids
    12034 zfs test send_encrypted_props can fail
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Rob Johnston <rob.johnston@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF