Actions
Bug #12043
closed
Streams ioctl for _I_CMD within kernel causes EFAULT
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:
Description
If a kernel module issues a streams ioctl call for _I_CMD, then it will fail with EFAULT.
This is because strioctl() wrongly attempts to use copyin() on the data despite the presence of the FKIOCTL flag.
Example code (vp is a pointer to a TLI vnode).
strcmd_t strcmd;
int32_t rval;
strcmd.sc_cmd = TI_GETMYNAME;
strcmd.sc_timeout = 1;
strcmd.sc_len = STRCMDBUFSIZE;
ASSERT0(VOP_IOCTL(vp, _I_CMD, (intptr_t)&strcmd, FKIOCTL, CRED(), &rval, NULL));
Related issues
Updated by Andy Fiddaman over 3 years ago
Review posted at https://code.illumos.org/c/illumos-gate/+/204
Updated by Andy Fiddaman over 3 years ago
At present, nothing in the kernel calls strioctl with _I_CMD but I've
tested that it now works from a kernel module, and exercised the
user- to kernel-space path using pfiles on TLI sockets, and verified it
still works.
Updated by Andy Fiddaman over 3 years ago
- Blocks Feature #12046: Provide /proc/<PID>/fdinfo/ added
Updated by Electric Monk over 3 years ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
git commit e63ea1f970505bef26ee06b3cef54076ad25b94e
commit e63ea1f970505bef26ee06b3cef54076ad25b94e
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date: 2019-12-03T18:28:38.000Z
12043 Streams ioctl for _I_CMD within kernel causes EFAULT
Reviewed by: John Levon <john.levon@joyent.com>
Reviewed by: Jason King <jason.king@joyent.com>
Approved by: Robert Mustacchi <rm@fingolfin.org>
Actions