Project

General

Profile

Actions
Copy link

Bug #12045

closed

segkmem_page_create(): Fire Walk With Me

Added by John Levon almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Levon
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

segkmem_page_create() uses a partially initialized stack value for seg: let's not play with fire any more here...

Actions
Copy link
 #1

Updated by John Levon almost 4 years ago

I tested this by booting. I also took a look at the paths underneath the function. As far as I could see, by default we'd only ever touch ->s_as, which is set, so this should have no effect. It's still worth doing of course.

Actions
Copy link
 #2

Updated by Electric Monk almost 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit e57e118bde6230c572bedb07470098811992cb01

commit  e57e118bde6230c572bedb07470098811992cb01
Author: John Levon <john.levon@joyent.com>
Date:   2019-12-04T14:54:11.000Z

    12045 segkmem_page_create(): Fire Walk With Me
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF