Project

General

Profile

Actions
Copy link

Bug #12074

closed

loader: cd9660_open() warn: is 'buf' large enough for 'struct iso_primary_descriptor'?

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Clean up smatch warning.

allocate buffer space with size: 

MAX(ISO_DEFAULT_BLOCK_SIZE, sizeof (struct iso_primary_descriptor))

Testing done: build/install/boot. Also verify disasm output we in fact do get buffer size 2048.

Actions
Copy link
 #1

Updated by Toomas Soome over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Toomas Soome over 3 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit e58ba7f235f59e7b79c7d4ce4fb02b7adc47273e

commit  e58ba7f235f59e7b79c7d4ce4fb02b7adc47273e
Author: Toomas Soome <tsoome@me.com>
Date:   2019-12-16T16:48:39.000Z

    12074 loader: cd9660_open() warn: is 'buf' large enough for 'struct iso_primary_descriptor'?
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF