Project

General

Profile

Actions

Bug #12090

closed

loader.efi: efi_readkey_ex needs to check the key despite the shift status or toggle status

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

From UEFI specification 2.8, page 434:

    "It should also be noted that certain input devices may not be able to produce
    shift or toggle state information, and in those cases the high order bit in
    the respective Toggle and Shift state fields should not be active." 

But we still need to check for ScanCode and UnicodeChar.

FreeBSD commit: https://svnweb.freebsd.org/base?view=revision&revision=355844
FreeSBD bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242660

Confirmed fix from FreeBSD user (in FreeBSD issue).

Actions #1

Updated by Toomas Soome almost 2 years ago

  • Subject changed from loader.efi: efi_readkey_ex needs to key despite the shift status or toggle status to loader.efi: efi_readkey_ex needs to check the key despite the shift status or toggle status
Actions #2

Updated by Toomas Soome almost 2 years ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit bf74bfd433cc5106d2fffc63678efb6ba4a3694c

commit  bf74bfd433cc5106d2fffc63678efb6ba4a3694c
Author: Toomas Soome <tsoome@me.com>
Date:   2019-12-18T20:50:05.000Z

    12090 loader.efi: efi_readkey_ex needs to check the key despite the shift status or toggle status
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF