devid_scsi_encode() should use a static format string
Updated by John Levon over 2 years ago
We directly pass inquiry data as a format string to cmn_err(). This doesn't seem like a good thing to be doing.
I also - briefly - tried turning on -Wformat-nonliteral in uts/ to catch other instances of this anti-pattern. Unfortunately there is a whole bunch of noise there. It might be nice one day to work through it.
Updated by Electric Monk over 2 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit d0972c645cf979856ed66c1c6a1f082383c90b0c Author: John Levon <firstname.lastname@example.org> Date: 2019-12-20T11:35:52.000Z 12093 devid_scsi_encode() should use a static format string Reviewed by: Jason King <email@example.com> Reviewed by: Toomas Soome <firstname.lastname@example.org> Approved by: Dan McDonald <email@example.com>