Bug #12093
closed
We directly pass inquiry data as a format string to cmn_err(). This doesn't seem like a good thing to be doing.
I also - briefly - tried turning on -Wformat-nonliteral in uts/ to catch other instances of this anti-pattern. Unfortunately there is a whole bunch of noise there. It might be nice one day to work through it.
I forgot to mention, Mike Gerdts discovered this.
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit d0972c645cf979856ed66c1c6a1f082383c90b0c
commit d0972c645cf979856ed66c1c6a1f082383c90b0c
Author: John Levon <john.levon@joyent.com>
Date: 2019-12-20T11:35:52.000Z
12093 devid_scsi_encode() should use a static format string
Reviewed by: Jason King <jason.brian.king@gmail.com>
Reviewed by: Toomas Soome <tsoome@me.com>
Approved by: Dan McDonald <danmcd@joyent.com>
Also available in: Atom
PDF