We directly pass inquiry data as a format string to cmn_err(). This doesn't seem like a good thing to be doing.
I also - briefly - tried turning on -Wformat-nonliteral in uts/ to catch other instances of this anti-pattern. Unfortunately there is a whole bunch of noise there. It might be nice one day to work through it.
Author: John Levon <email@example.com>
12093 devid_scsi_encode() should use a static format string
Reviewed by: Jason King <firstname.lastname@example.org>
Reviewed by: Toomas Soome <email@example.com>
Approved by: Dan McDonald <firstname.lastname@example.org>