Project

General

Profile

Actions

Bug #12115

closed

snoop: cast between incompatible function types

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with gcc 8:

    snoop_slp.c: In function 'interpret_slp_v2':
    snoop_slp.c:700:30: error: cast between incompatible function types from 'void (
    *)(int,  void *, int)' to 'int (*)()' [-Werror=cast-function-type]
          add_transient(src_port, (int (*)())interpret_slp);
                                  ^
    snoop_slp.c: In function 'interpret_slp_v1':
    snoop_slp.c:1421:27: error: cast between incompatible function types from 'void
    (*)(int,  void *, int)' to 'int (*)()' [-Werror=cast-function-type]
       add_transient(src_port, (int (*)())interpret_slp);
                               ^
    cc1: all warnings being treated as errors

Testing done: build/install/boot

Actions #1

Updated by Toomas Soome almost 2 years ago

  • Description updated (diff)
Actions #2

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit d6913e077df3706d8fe5649c00430704087fc6a2

commit  d6913e077df3706d8fe5649c00430704087fc6a2
Author: Toomas Soome <tsoome@me.com>
Date:   2019-12-27T14:27:13.000Z

    12115 snoop: cast between incompatible function types
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF