Project

General

Profile

Actions
Copy link

Bug #12123

closed

sendmail: cast between incompatible function types

Added by Toomas Soome almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors with gcc 8:

    signal.c: In function 'sm_signal':
    signal.c:57:19: error: cast between incompatible function types from 'sigfunc_t' {aka 'void (*)(int)'} to 'void (*)(int,  siginfo_t *, void *)' {aka 'void (*)(int,  struct siginfo *, void *)'} [-Werror=cast-function-type]
      n.sa_sigaction = (void(*)(int, siginfo_t *, void *)) handler;
                       ^
    cc1: all warnings being treated as errors

Testing done: build/install/boot

Cast over uintptr_t.

Actions
Copy link
 #1

Updated by Toomas Soome almost 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk almost 4 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit d9a262d9c411812b053dc33b7b8ab0f230c6fb00

commit  d9a262d9c411812b053dc33b7b8ab0f230c6fb00
Author: Toomas Soome <tsoome@me.com>
Date:   2019-12-27T18:00:27.000Z

    12123 sendmail: cast between incompatible function types
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF