Project

General

Profile

Actions

Bug #12125

closed

smbsrv: passing argument 1 to restrict-qualified parameter aliases with argument 4

Added by Toomas Soome almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cifs - CIFS server and client
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with gcc 8:

smbd_spool.c: In function 'smbd_load_printers':
smbd_spool.c:427:22: error: passing argument 1 to restrict-qualified parameter aliases with argument 4 [-Werror=restrict]
  rc = pthread_create(&tid, &attr, smbd_share_printers, &tid);
                      ^~~~                              ~~~~
cc1: all warnings being treated as errors

Testing done: build/install/boot

last argument is not used by smbd_share_printers, so just pass NULL there.

Actions #1

Updated by Toomas Soome almost 2 years ago

  • Description updated (diff)
Actions #2

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit f34e64d88f694155255ac1c93990904dbfa28af3

commit  f34e64d88f694155255ac1c93990904dbfa28af3
Author: Toomas Soome <tsoome@me.com>
Date:   2020-02-20T17:12:11.000Z

    12125 smbsrv: passing argument 1 to restrict-qualified parameter aliases with argument 4
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF