Project

General

Profile

Actions
Copy link

Bug #12128

closed

error: this statement may fall through

Added by Toomas Soome almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Build errors with gcc 8:

    ../common/errortouch.c: In function 'mustwrite':
    ../common/errortouch.c:675:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
       switch (inquire("Are you sure? ")) {
       ^~~~~~
    ../common/errortouch.c:685:2: note: here
      default:
      ^~~~~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot

Actions
Copy link
 #1

Updated by Toomas Soome almost 4 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 698f4ab6008be205f4362675967638572eef4f21

commit  698f4ab6008be205f4362675967638572eef4f21
Author: Toomas Soome <tsoome@me.com>
Date:   2019-12-27T17:38:22.000Z

    12128 error: this statement may fall through
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF