Project

General

Profile

Actions

Bug #12129

closed

make: this statement may fall through

Added by Toomas Soome almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with gcc 8:

    /code/illumos-gate/usr/src/cmd/make/bin/read.cc: In function 'void parse_makefile(Name, Source)':
    /code/illumos-gate/usr/src/cmd/make/bin/read.cc:1372:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
        switch (*++source_p) {
        ^~~~~~
    /code/illumos-gate/usr/src/cmd/make/bin/read.cc:1401:3: note: here
       case equal_char:
       ^~~~
    cc1plus: all warnings being treated as errors

Testing done: built/install/boot, gate build is able to continue.

Actions #1

Updated by Toomas Soome almost 2 years ago

  • Description updated (diff)
Actions #2

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 934b4812e2e03b8d7610bb247316af9a8a8998e4

commit  934b4812e2e03b8d7610bb247316af9a8a8998e4
Author: Toomas Soome <tsoome@me.com>
Date:   2019-12-27T12:56:14.000Z

    12129 make: this statement may fall through
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF