Project

General

Profile

Feature #12138

Want smbios pointer device decoding

Added by Robert Mustacchi about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

SMBIOS type 21 indicates built-in pointer devices. I was decoding a table from another system and noticed that we couldn't decode this. Since it was simple enough, I decided to do so. Here's an example of what that looks like:

$ LD_PRELOAD_32=../../lib/libsmbios/i386/libsmbios.so.1 ./smbios -t 21 ~/laptop.smbios
ID    SIZE TYPE
52    7    SMB_TYPE_POINTDEV (type 21) (built-in pointing device)

  Type: 5 (Track Point)
  Interface: 4 (PS/2)
  Buttons: 3

ID    SIZE TYPE
53    7    SMB_TYPE_POINTDEV (type 21) (built-in pointing device)

  Type: 7 (Touch Pad)
  Interface: 4 (PS/2)
  Buttons: 2

I also ran the current SMBIOS test suite (on top of 12133) and it passed:

TEST PASSED: slot tests
TEST PASSED: bad library version
TEST PASSED: memory device 3.2 / 3.2
TEST PASSED: memory device 3.2 / 3.3
TEST PASSED: memory device 3.3
TEST PASSED: memory device 3.3
TEST PASSED: processor additional information - amd64
TEST PASSED: processor additional information - riscv
TEST PASSED: processor additional information - bad table length 1
TEST PASSED: processor additional information - bad table length 2
TEST PASSED: processor additional information - bad table length 3
TEST PASSED: processor additional information - bad table length 4
TEST PASSED: processor additional information - bad type
#1

Updated by Electric Monk about 1 year ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 1d77dcda79ea31b52efaac166328f8a7f7359d5a

commit  1d77dcda79ea31b52efaac166328f8a7f7359d5a
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-01-11T07:43:21.000Z

    12138 Want smbios pointer device decoding
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF