Project

General

Profile

Actions
Copy link

Bug #12171

closed

pbchk traceback when checking .java file under python3

Added by Andy Fiddaman over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Andy Fiddaman
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Traceback (most recent call last):
  File "/data/omnios-build/omniosorg/bloody/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/git-pbchk", line 460, in <module>
    main(os.path.basename(sys.argv[0]), sys.argv[1:])
  File "/data/omnios-build/omniosorg/bloody/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/git-pbchk", line 452, in main
    pbchk(git_root(), parent_branch, None)
  File "/data/omnios-build/omniosorg/bloody/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/git-pbchk", line 419, in pbchk
    run_checks(root, parent, cmds, scmds)
  File "/data/omnios-build/omniosorg/bloody/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/git-pbchk", line 375, in run_checks
    output=s)
  File "/data/omnios-build/omniosorg/bloody/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/git-pbchk", line 284, in jstyle
    ret |= JStyle.jstyle(fh, output=output, picky=True)
  File "/data/omnios-build/omniosorg/bloody/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/../lib/python3.5/onbld/Checks/JStyle.py", line 54, in jstyle
    ret, tmpfile = processcheck('jstyle', options, fh, output)
  File "/data/omnios-build/omniosorg/bloody/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/../lib/python3.5/onbld/Checks/ProcessCheck.py", line 63, in processcheck
    p.stdin.write(line)
TypeError: a bytes-like object is required, not 'str'
Actions
Copy link
 #1

Updated by Andy Fiddaman over 1 year ago

Actions
Copy link
 #2

Updated by Andy Fiddaman over 1 year ago

Testing:

Python2

% python2 proto/root_i386-nd/opt/onbld/bin/git-pbchk
Comments:
These comments are not valid bugs:
  x

Copyrights:
../cmd/print/printmgr/com/sun/admin/pm/client/pmInstallPrinter.java: no copyright claim for current year found
../prototypes/prototype.java: no copyright claim for current year found

Java style:
../cmd/print/printmgr/com/sun/admin/pm/client/pmInstallPrinter.java: 47: improper first line of block comment
../prototypes/prototype.java: 19: last line in file is blank

Python3

% python3 proto/root_i386-nd/opt/onbld/bin/git-pbchk
Comments:
These comments are not valid bugs:
  x

Copyrights:
../prototypes/prototype.java: no copyright claim for current year found
../cmd/print/printmgr/com/sun/admin/pm/client/pmInstallPrinter.java: no copyright claim for current year found

Java style:
../prototypes/prototype.java: 19: last line in file is blank
../cmd/print/printmgr/com/sun/admin/pm/client/pmInstallPrinter.java: 47: improper first line of block comment
Actions
Copy link
 #3

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 1081175181bc5c4495f7bc7f565bf3af4f1d6085

commit  1081175181bc5c4495f7bc7f565bf3af4f1d6085
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2020-01-08T22:13:50.000Z

    12171 pbchk traceback when checking .java file under python3
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF