Project

General

Profile

Actions

Feature #12178

closed

Allow bytes to be removed from a custr

Added by Jason King almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Add functions to libcustr to allow the remove of bytes from the beginning, end, and in the middle of a custr. We are using this for some SmartOS specific code, but they seem like they could be generally useful for other illumos-gate consumers (the libcustr library is still kept private) and we'd prefer to avoid any divergence from the upstream if we can avoid it.

This also adds the start of some libcustr tests as well.

Actions #1

Updated by Jason King almost 2 years ago

  • Subject changed from Allow bytes to removed from a custr to Allow bytes to be removed from a custr
Actions #2

Updated by Jason King almost 2 years ago

For testing, I booted a BE with this change and ran the new custr tests that test the new functions as part of this change.

In addition, the EDAR (encrypted data at rest) project on SmartOS has been using these changes for several months without any problems.

Actions #3

Updated by Electric Monk almost 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 356ce177517a15babb8fd801d490f239298643b7

commit  356ce177517a15babb8fd801d490f239298643b7
Author: Jason King <jason.king@joyent.com>
Date:   2020-01-14T15:36:41.000Z

    12178 Allow bytes to be removed from a custr
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions

Also available in: Atom PDF