zfs test suite calculates md5 digests suboptimally
While going through the RTI for #12034 Dan noted that we could simplify some testing code by using digest(1) instead using md5sum(1) and piping the output to awk.
We can use digest(1) to replace the
md5sum | awk pattern pretty easily:
$ digest -a md5 README.md 7ed980493c1161d119bd89dc85819b3f
Updated by Kody Kantor over 2 years ago
To test this I booted a new environment with these changed, crafted a runfile that contains the modified tests, and ran it. All the tests pass, just as before.
$ ./bin/zfstest -c ./kkantor.run Test: /opt/zfs-tests/tests/functional/cli_root/zfs_receive/setup (run as root) [00:00] [PASS] Test: /opt/zfs-tests/tests/functional/cli_root/zfs_receive/zfs_receive_from_encrypted (run as root) [00:02] [PASS] Test: /opt/zfs-tests/tests/functional/cli_root/zfs_receive/zfs_receive_raw (run as root) [00:05] [PASS] Test: /opt/zfs-tests/tests/functional/cli_root/zfs_receive/zfs_receive_raw_incremental (run as root) [00:08] [PASS] Test: /opt/zfs-tests/tests/functional/cli_root/zfs_receive/cleanup (run as root) [00:00] [PASS] Test: /opt/zfs-tests/tests/functional/history/setup (run as root) [00:00] [PASS] Test: /opt/zfs-tests/tests/functional/history/history_003_pos (run as root) [00:46] [PASS] Test: /opt/zfs-tests/tests/functional/history/cleanup (run as root) [00:00] [PASS] Test: /opt/zfs-tests/tests/functional/rsend/setup (run as root) [00:06] [PASS] Test: /opt/zfs-tests/tests/functional/rsend/send-c_volume (run as root) [00:03] [PASS] Test: /opt/zfs-tests/tests/functional/rsend/send-wDR_encrypted_zvol (run as root) [00:14] [PASS] Test: /opt/zfs-tests/tests/functional/rsend/send_encrypted_props (run as root) [00:14] [PASS] Test: /opt/zfs-tests/tests/functional/rsend/cleanup (run as root) [00:00] [PASS] Results Summary PASS 13 Running Time: 00:01:43 Percent passed: 100.0%
Updated by Electric Monk over 2 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit e3bf7d5a53699b06ef4e776789b585322c4bf8ed Author: Kody Kantor <firstname.lastname@example.org> Date: 2020-01-23T18:22:16.000Z 12189 zfs test suite calculates md5 digests suboptimally Reviewed by: Dan McDonald <email@example.com> Reviewed by: Toomas Soome <firstname.lastname@example.org> Approved by: Gordon Ross <email@example.com>