Project

General

Profile

Actions
Copy link

Bug #12193

closed

zonestatd: Wrong indentation in zsd_usage_cache_update()

Added by Marcel Telka over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Marcel Telka
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Lines 3878-3889 are not indented properly here in usr/src/cmd/zonestat/zonestatd/zonestatd.c:

3876    /* Update the current cache pointer */
3877    (void) mutex_lock(&g_usage_cache_lock);
3878        old = g_usage_cache;
3879        cache->zsuc_ref = 1;
3880        cache->zsuc_gen = g_gen_next;
3881        usage->zsu_gen = g_gen_next;
3882        usage->zsu_size = size;
3883        g_usage_cache = cache;
3884        if (old != NULL) {
3885            old->zsuc_ref--;
3886            if (old->zsuc_ref == 0)
3887                free(old);
3888        }
3889        g_gen_next++;
3890    /* Wake up any clients that are waiting for this calculation */
3891    if (g_usage_cache_kickers > 0) {

Related issues

Related to illumos gate - Bug #12201: Enable smatch for zonestat and zonestatdClosedMarcel Telka

Actions
Actions
Copy link
 #2

Updated by Marcel Telka over 3 years ago

  • Status changed from In Progress to Pending RTI
Actions
Copy link
 #3

Updated by Marcel Telka over 3 years ago

  • Related to Bug #12201: Enable smatch for zonestat and zonestatd added
Actions
Copy link
 #4

Updated by Electric Monk over 3 years ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit 8c4f148689a42031a168cdc4c81062735db025e0

commit  8c4f148689a42031a168cdc4c81062735db025e0
Author: Marcel Telka <marcel@telka.sk>
Date:   2020-01-24T16:30:58.000Z

    12193 zonestatd: Wrong indentation in zsd_usage_cache_update()
    Reviewed by: Matthias Scheler <mscheler@tintri.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF