Project

General

Profile

Bug #12200

fmd: Wrong prerequisites for generated files

Added by Marcel Telka 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

$ cd usr/src/cmd/fm/fmd/i386/
$ make fmd_svc_adm.c
`fmd_svc_adm.c' is up to date.
$ touch ../common/fmd_rpc_adm.x
$ make fmd_svc_adm.c
/usr/bin/rpcgen -CMN -h -o ../common/fmd_rpc_adm.h ../common/fmd_rpc_adm.x
/usr/bin/rpcgen -CMN -m -o fmd_svc_adm.c `echo ../common/fmd_rpc_adm.h | sed 's/h$/x/'`
$ touch ../common/fmd_rpc_adm.h
$ make fmd_svc_adm.c
/usr/bin/rpcgen -CMN -m -o fmd_svc_adm.c `echo ../common/fmd_rpc_adm.h | sed 's/h$/x/'`
$

Four files (fmd_svc_adm.c, fmd_svc_api.c, fmd_xdr_adm.c, and fmd_xdr_api.c) are affected by this.


Related issues

Related to illumos gate - Bug #12188: libfmd_adm: Wrong prerequisites for generated filesClosedMarcel Telka

Actions
#1

Updated by Marcel Telka 11 months ago

  • Related to Bug #12188: libfmd_adm: Wrong prerequisites for generated files added
#2

Updated by Marcel Telka 11 months ago

Testing with the fix:

$ cd usr/src/cmd/fm/fmd/i386/
$ make fmd_svc_adm.c
`fmd_svc_adm.c' is up to date.
$ touch ../common/fmd_rpc_adm.x
$ make fmd_svc_adm.c
/usr/bin/rpcgen -CMN -m -o fmd_svc_adm.c ../common/fmd_rpc_adm.x
$ touch ../common/fmd_rpc_adm.h
$ make fmd_svc_adm.c
`fmd_svc_adm.c' is up to date.
$

#4

Updated by Marcel Telka 11 months ago

  • Status changed from In Progress to Pending RTI
#5

Updated by Electric Monk 11 months ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit 3b379e2a4b3fe1592962563cb8c50c330ce393d8

commit  3b379e2a4b3fe1592962563cb8c50c330ce393d8
Author: Marcel Telka <marcel@telka.sk>
Date:   2020-01-20T15:17:33.000Z

    12200 fmd: Wrong prerequisites for generated files
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF