Project

General

Profile

Actions

Bug #12209

closed

nvme driver will iterate beyond the end of the DMA cookie chain

Added by Paul Winder over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Function nvme_fill_prp() iterates beyond the last DMA cookie using ddi_dma_nextcookie().
It doesn't attempt to use anything beyond the end, but it will cause a panic post integration of IPD 13

Actions #1

Updated by Paul Winder over 2 years ago

Review is: https://code.illumos.org/c/illumos-gate/+/322/1

With the code from https://code.illumos.org/c/illumos-gate/+/310 (IPD 13) the system panics 100%.
After fix panic has gone

Actions #2

Updated by Electric Monk over 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 80 to 100

git commit 709d065fa472580d0fd685caa2fe31c61c2fa25c

commit  709d065fa472580d0fd685caa2fe31c61c2fa25c
Author: Paul Winder <paul@winders.demon.co.uk>
Date:   2020-01-21T15:27:50.000Z

    12209 nvme driver will iterate beyond the end of the DMA cookie chain
    Reviewed by: Robert Mustacchi <rm+illumos@fingolfin.org>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF