Project

General

Profile

Feature #12222

Want ctfwsdiff to diff workspaces for CTF

Added by Robert Mustacchi about 1 year ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Having written an ad-hoc tool a few different times to do this, I thought it'd be useful to add a wsdiff like tool that uses ctfdump -c to look at the difference between two workspaces for CTF and reports on what's changed between files. While a little simple, this helps give us confidence that changes in the ctf tooling haven't caused changes in the existing gate (or have caused ones that we expect).


Related issues

Related to illumos gate - Feature #13233: want unified diff option for wsdiffClosedAndy Fiddaman

Actions
#1

Updated by Electric Monk 7 months ago

  • Gerrit CR set to 324
#2

Updated by Andy Fiddaman 3 months ago

  • Assignee changed from Robert Mustacchi to Andy Fiddaman
#3

Updated by Andy Fiddaman 3 months ago

  • Related to Feature #13233: want unified diff option for wsdiff added
#4

Updated by Andy Fiddaman 3 months ago

To test the change in the referenced Gerrit review, I ran the old and new wsdiff to compare a DEBUG and non-DEBUG workspace and compared their results.The same differences were identified by both versions.

I then made a small change to the source - added a new element to the struct metaslab struct - and built again, then used the new version to compare the old and new non-DEBUG workspaces.

The updated tool showed the differences in the SUNW_ctf sections of affected objects, as expected.

I also tested with unified diff output.

#5

Updated by Andy Fiddaman 3 months ago

  • Gerrit CR changed from 324 to 1002
#6

Updated by Electric Monk 3 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit b7c90935fabdc1d4ac22d416b197b46081cdaee4

commit  b7c90935fabdc1d4ac22d416b197b46081cdaee4
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2020-10-24T14:47:08.000Z

    12222 Want ctfwsdiff to diff workspaces for CTF
    13233 want unified diff option for wsdiff
    13240 wsdiff should not compare .SUNW_dof sections
    Reviewed by: Rich Lowe <richlowe@richlowe.net>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Also available in: Atom PDF