Project

General

Profile

Actions
Copy link

Bug #12224

closed

ctfconvert conv backend error missing newline

Added by Robert Mustacchi over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

When ctfconvert prints the conversion backend error it's missing a new line. The backend itself isn't required to have one and most cases don't. This helpfully makes sure that we always have that in the case of an error.

Actions
Copy link
 #1

Updated by Robert Mustacchi over 2 years ago

I tested this by hitting the error case again and ensuring new lines were present.

Actions
Copy link
 #2

Updated by Electric Monk over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 6d9e11ccb59a5d4ea2127e1791163333c4337a08

commit  6d9e11ccb59a5d4ea2127e1791163333c4337a08
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-02-13T05:12:47.000Z

    12224 ctfconvert conv backend error missing newline
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Jason King <jason.king@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF