Project

General

Profile

Actions

Feature #12225

closed

normalize complex float names across compilers

Added by Robert Mustacchi almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

When clang emits dwarf, it calls all different sized complex values 'complex' regardless of whether we called it a complex float, complex double, or complex long double. These are still distinguishable because of the actual byte size of the emitted data. Just as we normalize the integer type names, we should normalize the complex type names to match what we're seeing with GCC so that everything is more consistent and it's a little clearer to the user what the size and type of complex that they're encountering is.

Actions #1

Updated by Robert Mustacchi over 1 year ago

I tested this by seeing that clang (with other changes present) passed the CTF test suite and by using ctfwsdiff to verify that nothing changed in the ctf (aside from in libctf) between builds without this change and those with the other CTF changes.

Actions #2

Updated by Electric Monk over 1 year ago

  • Status changed from New to Closed

git commit 2e25d8e1fe9b3743d7dec073fd05a9f95fbca2a7

commit  2e25d8e1fe9b3743d7dec073fd05a9f95fbca2a7
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-02-17T10:31:15.000Z

    12225 normalize complex float names across compilers
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF